Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-18113] Specify Android build tools version #6593

Merged
merged 2 commits into from Feb 13, 2015

Conversation

skypanther
Copy link
Contributor

@eric34
Copy link
Contributor

eric34 commented Jan 30, 2015

Some items for consideration:
I suggest we use the latest build tools as the default. This would allow the latest build to be used which would continue current behavior. If the user wishes to select a different installed version, that would satisfy the needs of the original ticket reporter.

In regards to the supported range, there will be an issue if the range includes non-working versions. In our case, this would be the situation at ship time if we include version 21. Version 21.0.1 fails our build, as does 21.0.2. 21.0.3 works however. Since we have no mechanism to allow some or disallow others, I wonder if we feel this is a valid approach to track what is supported.

There is one other consideration: The dependency chain that includes the Ti SDK, the Android SDK and the Build tools version must be taken into consideration. For example, with material theme support, the min compile target is API 21, and this requires build tools 21. So selecting another version of build tools would fail to build in this case.

@skypanther
Copy link
Contributor Author

Our thought behind not using the latest build tools as the default was so that we could control the tooling versions a bit more tightly. In the past, developers update tooling as soon as Google releases it and if there's an issue, we get hammered with issues. In this way, we have to release a new SDK that specifically supports the new build tools.

As implemented, the PR enables developers to select the newer build tools version manually. However, by default, only versions within the supported range are auto-selected.

Would you file a new ticket to address the "non-contiguous range" issue you identified? The appc.version.satisfies logic will need to be updated to support this sort of situation.

As for point three, the dependency chain is accounted for. The build tool's Pkg Revision file is checked against supported version information in the package.json file. The version is marked as not-supported if required versions don't match.

@skypanther
Copy link
Contributor Author

Per conversation with Ingo, Eric, and Praveen, I'm merging this PR. We will consider additional enhancements (segmented ranges, warnings) in separate tickets.

skypanther added a commit that referenced this pull request Feb 13, 2015
[TIMOB-18113] Specify Android build tools version
@skypanther skypanther merged commit 93ee005 into tidev:master Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants