[TIMOB-18359] iOS: Fix bug for retrieving birthday in iOS8 and other contact updates #6598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug for retrieving birthday for iOS8 Added support for Social Profile Added support for more Instant Messengers Added support for Alternative Birthday (ios8 only) Edited Contacts yml docs
| description: | | ||
| The format of the dictionary accepted by this property is as follows: | ||
|
|
||
| * Keys: any of `home`, `work` and/or `other`. |
There was a problem hiding this comment.
I think the keys are incorrect. Shouldn't they be facebookProfile, flickrProfile etc? I think any String value is accepted but there are predefined values in iOS
There was a problem hiding this comment.
As explained in the below note, the current sdk reads the input for instantMessage in this format. And I followed the same format for socialProfile so that the behavior and usage is similar. The predefined values are actually the service key values explained in the docs, and are case sensitive. Will emphasize in the next commit.
|
The code works fine but the documentation and sample need work. Code reviewed. Please address comments |
|
CR + FR ok. APPROVED |
vishalduggal
added a commit
that referenced
this pull request
Jan 30, 2015
[TIMOB-18359] iOS: Fix bug for retrieving birthday in iOS8 and other contact updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug for retrieving birthday for iOS8
Added support for Social Profile
Added support for more Instant Messengers
Added support for Alternative Birthday (ios8 only)
Edited Contacts yml docs
Test case in JIRA: https://jira.appcelerator.org/browse/TIMOB-18359