Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-17675] iOS: Add support for SplitWindow on iPhone #6601

Merged
merged 12 commits into from Jan 30, 2015

Conversation

vishalduggal
Copy link
Contributor

Jira Ticket TIMOB-17675

default: false

- name: portraitSplit
summary: Determines the width of the `masterView` in portrait mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should mention between 0.25 to 0.5

@vishalduggal
Copy link
Contributor Author

Done. Ready for review.

@cheekiatng
Copy link
Contributor

CR and FT passed. Merging.

cheekiatng added a commit that referenced this pull request Jan 30, 2015
[TIMOB-17675] iOS: Add support for SplitWindow on iPhone
@cheekiatng cheekiatng merged commit 1b25285 into tidev:master Jan 30, 2015
@vishalduggal vishalduggal deleted the timob-17675 branch February 5, 2015 17:13
@hansemannn
Copy link
Collaborator

This PR does not use the native UISplitViewController like proposed in the linked ticket. Does that have a reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants