[TIMOB-17446] CLI args to specify i18n and platform locations #6602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To keep the arguments consistent with the existing arguments such as --project-dir or --output-dir, I would recommend to keep the existing arguments as --i18n-dir and |
| if(customI18n && fs.existsSync(path.join(path.resolve(projectDir), customI18n))) { | ||
| projectDir = path.join(projectDir, customI18n); | ||
| } | ||
| } |
There was a problem hiding this comment.
Just being nitty-gritty. Can you format the above block ? For ex. spacing issues with if conditions - there should be a space between if and (
|
FR passed. Should be good to merge after changing the arguments. |
pinnamur
pushed a commit
that referenced
this pull request
Jan 30, 2015
[TIMOB-17446] CLI args to specify i18n and platform locations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-17446