[TC-5357] Support destructive alert style

[hansemannn]

JIRA reference: https://jira.appcelerator.org/browse/TC-5357

[pec1985]

This line is a bit confusing and not easy to follow due to the multiple ternary operators. If would be better to spread the out for clarity purposes, something like this:

UIAlertActionStyle style;
if (curIndex == cancelIndex) {
    style = UIAlertActionStyleCancel;
} else if (curIndex == destructiveIndex) {
    style = UIAlertActionStyleDestructive;
} else {
    style  = UIAlertActionStyleDefault;
}

[pec1985]

Also, if this is iOS 8 an above only, make sure you check for that with:

if ([TiUtils isIOS8OrGreater]) { ..... }

[pec1985]

PR reviewed, left a couple of comments.

[hansemannn]

Thank you! Comments are reasonable, will have a look at it!

[hansemannn]

Updated docs and code readability as well as a bounding-check like it is done with the cancel-button. I think the iOS 8 check is not necessary in this case, because the code is already in the conditional iOS 8 block to support the UIAlertController.

[pec1985]

One more thing... the destructive index is missing from the click event. For consistency, add it here as well fireClickEventWithAction:

NSMutableDictionary *event = [NSMutableDictionary dictionaryWithObjectsAndKeys:
                               NUMUINTEGER(indexOfAction),@"index",
                               [NSNumber numberWithInt:cancelIndex],@"cancel",
                               nil];

[hansemannn]

Added the destructive index and implemented a quick sample example code to test:

var win = Ti.UI.createWindow({
    backgroundColor: "#fff"
});

var button = Ti.UI.createButton({
    title: "Show destructive dialog"
});

var dialog = Ti.UI.createAlertDialog({
    title: "Proceed",
    message: "Do you really want to proceed?",
    destructive: 0,
    cancel: 1,
    buttonNames: ["Destructive", "Cancel", "Proceed"]
});

button.addEventListener("click", function() {
    dialog.show();
});

dialog.addEventListener("click", function(e) {
    Ti.API.info(e);
});

win.add(button);

win.open();

Output in the console:

[INFO] :   {
[INFO] :       bubbles = 1;
[INFO] :       cancel = 1;
[INFO] :       cancelBubble = 0;
[INFO] :       destructive = 0;
[INFO] :       index = 0;
[INFO] :       source = "[object TiUIAlertDialog]";
[INFO] :       type = click;
[INFO] :   }

[pec1985]

i have opened a new PR with your commits for Titanium master branch #6842

[pec1985]

There is one minor thing missing in the documentation. The since tag (for Ti SDK) and the osver for the iOS version. You can simple cherry pick from master since I already merged that

git cherry-pick cfcbc96

cfcbc96

[hansemannn]

Closing this outdated PR in favor of #6842