Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(TiShadow): Android service dont working in tishadow #6698

Closed
wants to merge 2 commits into from

Conversation

rotorgames
Copy link

Android Service, does not work with tishadow.

Titanium uses the directory android_asset, and tishadow retains all the resources in the appdata-private, so running the service was impossible.

The changes allow us to determine when the compilation comes with tishadow, and allow you to take the source files for the service of appdata-private.

Please accept these changes, it is important.

P.S. I apologize for my bad English.

@dbankier
Copy link
Contributor

dbankier commented Mar 9, 2015

+1

@caspahouzer
Copy link
Contributor

+1

@ingo
Copy link
Contributor

ingo commented Mar 10, 2015

Hi All. Thank you for the PR, and we'd like to help. A few notes:

  1. For an item like this, we need a JIRA ticket and test case
  2. This change needs to be product-agnostic. So we need a way of adding this so that tishadow can take advantage of it, but is not tishadow-specific.
  3. Documentation updates for areas where this changes behavior.

Thanks!

@rotorgames
Copy link
Author

@ingo @dbankier Thanks for the quick reply.

Can be done to take any titanium files from appdata-private directory, and it will be included by using <property name = "useDataDirectory" type = "bool"> true </ property>.

TiShadow will add this property to tiapp.xml.

How do you like this idea?

@ingo
Copy link
Contributor

ingo commented Mar 10, 2015

@rotorgames Is there a need to make this property work on other platforms too? It might be better to specify which directory to use, rather than just to use a different one. @ashcoding @hieupham007 @pec1985 thoughts?

@rotorgames
Copy link
Author

@ingo As far as I know, this problem is only on android, but it can do as you want. Probably it will be even better and more convenient.

@ashcoding
Copy link
Contributor

@ingo I'll go and investigate things out first.

@rotorgames
Copy link
Author

@hansemannn
Copy link
Collaborator

Closing PR since it wants to merge into the stale branch 3_5_X. Please submit a new one for master and we can take care of it, thank you!

@hansemannn hansemannn closed this Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants