Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-18662] Bump Titanium SDK Version to 3.5.2 #6699

Merged
merged 1 commit into from Mar 9, 2015

Conversation

jonalter
Copy link
Contributor

@jonalter jonalter commented Mar 9, 2015

@ingo
Copy link
Contributor

ingo commented Mar 9, 2015

Approved. Merging.

ingo added a commit that referenced this pull request Mar 9, 2015
[TIMOB-18662] Bump Titanium SDK Version to 3.5.2
@ingo ingo merged commit 8eed657 into tidev:3_5_X Mar 9, 2015
@jonalter jonalter deleted the TIMOB-18662 branch March 9, 2015 18:12
@jhaynie
Copy link
Contributor

jhaynie commented Mar 10, 2015

do we really need to do PR for stuff as simple as this?

@ingo
Copy link
Contributor

ingo commented Mar 10, 2015

Yes, because we've forgotten to update both files. The fact we have both files is super-annoying. Once we solve https://jira.appcelerator.org/browse/TIMOB-18508, then no.

@jhaynie
Copy link
Contributor

jhaynie commented Mar 10, 2015

ok, can we just fix that? that seems like a quick fix.

@ingo
Copy link
Contributor

ingo commented Mar 10, 2015

Yes--problem is it is reused in a bunch of places. Trying to get to it. I am actively trying to refine as much process as quickly as possible :)

@ingo ingo mentioned this pull request Mar 10, 2015
@jhaynie
Copy link
Contributor

jhaynie commented Mar 10, 2015

can't we just put it in the top level build to generate the right value in both places as-is. at least then you don't hard code it in two places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants