Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-18143] iOS Fixed searchbar background image #6752

Merged
merged 3 commits into from May 12, 2015

Conversation

pec1985
Copy link
Contributor

@pec1985 pec1985 commented Mar 27, 2015

The commit should have said "background image" instead of "background color"
ticket: https://jira.appcelerator.org/browse/TIMOB-18143

@pec1985 pec1985 changed the title [TIMOB-18143] iOS Fixed searchbar background color [TIMOB-18143] iOS Fixed searchbar background image Mar 27, 2015
@@ -141,11 +141,22 @@ -(void)setBarColor_:(id)value
-(void)setBackgroundImage_:(id)arg
{
UIImage *image = [self loadImage:arg];
[[self searchBar] setBackgroundImage:image];
if([TiUtils isIOS7OrGreater]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS7 is our minimum supported version, so this if condition will always return true. You can remove it

@cheekiatng
Copy link
Contributor

CR and FT Passed. Merging.

cheekiatng added a commit that referenced this pull request May 12, 2015
[TIMOB-18143] iOS Fixed searchbar background image
@cheekiatng cheekiatng merged commit 1188d02 into tidev:master May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants