Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-18767] Android: Add support for xxxhigh to displayCaps.density #6754

Closed
wants to merge 1 commit into from
Closed

[TIMOB-18767] Android: Add support for xxxhigh to displayCaps.density #6754

wants to merge 1 commit into from

Conversation

FokkeZB
Copy link
Contributor

@FokkeZB FokkeZB commented Mar 30, 2015

No description provided.

@hieupham007
Copy link
Contributor

Code reviewed. Looks good

@hieupham007
Copy link
Contributor

Functionally tested. The nexus 6 is reporting '560' DPI instead of '640'.

@FokkeZB
Copy link
Contributor Author

FokkeZB commented Apr 10, 2015

@hieupham007, yes and TVs report 213 and because we're having 160/medium as the default that gives odd results. We should do >= instead of ==

@hieupham007
Copy link
Contributor

I just submit #6776, added support for a few densities. I think this should fix our problem

@cheekiatng
Copy link
Contributor

Closing PR since TIMOB-18767 is resolved and closed. Thanks!

@cheekiatng cheekiatng closed this May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FokkeZB @hieupham007 @cheekiatng