Timob 18854 : Add Delegate & Reply for openParentApplication to Titanium #6803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for openParentApplication which requires handleWatchKitExtensionRequest
| ENSURE_ARG_COUNT(args, kArgCount); | ||
|
|
||
| NSString *key = [TiUtils stringValue:[args objectAtIndex:kArgKey]]; | ||
| NSDictionary *userInfo = [args objectAtIndex:kArgUserInfo]; |
There was a problem hiding this comment.
The kArgUserInfo value is 1 so it should be inside the if([args count] > 1) block
|
@benbahrenburg thanks for this PR. I left a minor comment that needs to be addressed in order to avoid crashes. |
|
@pec1985 documentation added. Dictionary argument inlined. |
|
Closing PR, fixed a minor docuemtnation issue, new PR with @benbahrenburg's changes here: #6826 Thanks Ben! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to ticket TIMOB-18854
Included in this PR is:
1.Addition of the required Application Delegate
2.Ti.App.iOS notification with information provided by the calling WatchKit Extension
3.sendWatchExtensionReply method to reply back to the openParentApplication
A detail of all the changes included in this PR is available here