[TIMOB-18765] iOS: Fix for uiimageview regression project name or file name has a space

[cheekiatng]

JIRA: https://jira.appcelerator.org/browse/TIMOB-18765

[vishalduggal]

This will work for the fix but it is not the right fix. For example if the image was specified as 'image%1.png' this if condition will fail and you would get a nil result.

The real problem is in ImageView loadUrl function where we are using
NSURL *url_ = [TiUtils toURL:[img absoluteString] proxy:self.proxy];

What we sould be using is
NSURL *url_ = [TiUtils toURL:[img path] proxy:self.proxy];

or the passed in img argument directly since it has already been converted to a URL

[vishalduggal]

Code reviewed. CR/FR Failed.

[vishalduggal]

You might also want to cleanup the
+(NSURL*)toURL:(NSString *)relativeString relativeToURL:(NSURL *)rootPath method in TiUtils.m
We have special handling of URL's with http and https schemes.

If - (NSString *)stringByAddingPercentEscapesUsingEncoding:(NSStringEncoding)enc; is performing the same functionality we should remove the block of code that transforms these remote URL's

[cheekiatng]

Good point. Thanks!

[vishalduggal]

CR + FR ok. APPROVED