[TIMOB-19919] separates event and callback for onBackPressed #6859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code reviewed and functionally tested. Looks good |
hieupham007
added a commit
that referenced
this pull request
Jan 5, 2016
[AC-96] separates event and callback for onBackPressed
|
Would be great to have the |
|
As mentioned in https://jira.appcelerator.org/browse/TIMOB-19919 |
|
Revert button not able to create PR automatically, will be required to manually create a PR to revert the changes. |
ashcoding
changed the title
|
PR: #7780 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test code in ticket description: AC-96
This allows you to listen to the back button event without influencing the default behavior. Therefor, a new property was added (
Ti.UI.Window.onBack) which lets you define a callback that explicitly overrides onBackPressed.The existing
androidbackevent fires without impact on the behavior. This allows you to execute additional code.