[TIMOB-18905] Android: Update Appcompat to 22.1 #6869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashcoding
force-pushed
the
TIMOB-18905
branch
2 times, most recently
from
df8b514
to
5f42c58
Compare
|
Note to anyone looking at this in the future, while updating this, encountered an error <item name="windowNoTitle">true</item>This was needed and added to the various themes in android\templates\build\theme.xml |
|
Is this a work-in progress, or does it have support for the material themed dialogs we talked about? |
|
@hieupham007 this is just the Appcompat update. The material themed dialogs will be in another PR. This is ready for reviewing. |
|
code reviewed and functionally tested. Request accepted |
hieupham007
added a commit
that referenced
this pull request
Jun 2, 2015
[TIMOB-18905] Android: Update Appcompat to 22.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.appcelerator.org/browse/TIMOB-18905
To test, run scons and KS.