Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-18851] Implement the filtering of analytics events for iOS #6923

Merged
merged 2 commits into from Jun 20, 2015

Conversation

pec1985
Copy link
Contributor

@pec1985 pec1985 commented Jun 18, 2015

{
if ([AnalyticsModule isEventFltered:@"ti.geo"]) {
return;
}
static BOOL analyticsSend = NO;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was trying to test and realised ti.geo is never fired anyway, both with and without the new code. have to remove 'static' here, otherwise analyticsSend will always be set to YES.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why that's there, it was there already. Let me do some research and find out

@lokeshchdhry
Copy link
Contributor

PR Approved
Tested using the custom 4.1.0 build given by @pec1985 .
As of now only ti.geo events are filtered by using Ti.Analytics.filterEvents(['ti.geo']) in the app.
Checked the following:

  1. We get ti.geo events with out the filterEvents method -- Passed. We got ti.geo as expected.
  2. We get ti.geo events with the filterEvents method -- Passed. We did not get ti.geo which is expected as they are filtered.
  3. Any other events other than ti.geo are filtered -- Passed. No other events are filtered apart from ti.geo.

@cheekiatng
Copy link
Contributor

Approved! Merging.

cheekiatng added a commit that referenced this pull request Jun 20, 2015
[TIMOB-18851] Implement the filtering of analytics events for iOS
@cheekiatng cheekiatng merged commit d239018 into tidev:master Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants