[TIMOB-19002] iOS9: Update Ti.Contacts to support new API #6945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
completed authorization request and check completed showContacts included new contacts delegates First modifications to TiContactsPerson
added properties and labels in TiContactsPerson added ‘reload’ listener added getPersonByIdentifier and getGroupByIdentifier updated getPeopleWithName
Added saveRequest property for deleting implemented `select property` for `showContacts` implemented getImage for TiContactPerson
createPerson removePerson createGroup removeGroup addMember removeMember getAllMembers and getSortedMembers
Added documentation
|
Results:
@cheekiatng Can you check that? |
|
Yes the app crashes when trying to remove already removed contact. We have stated that in the docs here http://docs.appcelerator.com/platform/latest/#!/api/Titanium.Contacts-method-removePerson that this will result in unexpected behaviors. And unfortunately i couldn't figure a way to make it not crash either. |
|
Crashs resolved, can be merged. |
hansemannn
added a commit
that referenced
this pull request
Jul 8, 2015
[TIMOB-19002] iOS9: Update Ti.Contacts to support new API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-19002