Timob 6096: Android: View: Rhino only: Event propagation not showing window info when clicking anywhere #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may need to wrap these events so the "source" object is the wrapper window proxy instead of "this.window" |
|
|
||
| // Add event listeners to this.window and update the source of events to this after the window opens | ||
| var self = this; | ||
| function addListener(name, listener) { |
There was a problem hiding this comment.
Let's move this "addListener" function into a single spot so we don't duplicate code
|
Code and functional review passed, Request accepted |
|
Code review accepted |
billdawson
added a commit
that referenced
this pull request
Nov 18, 2011
Timob 6096: Android: View: Rhino only: Event propagation not showing window info when clicking anywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket http://jira.appcelerator.org/browse/TIMOB-6096
To test it, KS Base UI > View > Events Propagation. When clicking anywhere in the window, the bottom label should show text.