Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-17595] iOS: The app fails to install on iOS device after a second iOS device is also plugged in #7129

Merged
merged 1 commit into from Sep 8, 2015

Conversation

FokkeZB
Copy link
Contributor

@FokkeZB FokkeZB commented Sep 7, 2015

NOTE: This is not a fix but an improvement of the error message

https://jira.appcelerator.org/browse/TIMOB-17595

@hansemannn
Copy link
Collaborator

I think @cb1kenobi is already working on a fix on the CLI side to make this message obsolet.

@FokkeZB
Copy link
Contributor Author

FokkeZB commented Sep 7, 2015

He asked me for a PR (see JIRA) but a full fix is always better ;)

@hansemannn
Copy link
Collaborator

Great! I would prefer checking against the error code (0xe800007f) rather then the else-case for this (which already exists in line 185). But Chris will review I think :-).

@cb1kenobi
Copy link
Contributor

I'm fine with the messaging. If we don't handle a specific error code, then we have no idea what's up and the only thing we can recommend is to reconnect and try again.

APPROVED

@FokkeZB do you have a 5_0_X backport?

cb1kenobi added a commit that referenced this pull request Sep 8, 2015
[TIMOB-17595] iOS: The app fails to install on iOS device after a second iOS device is also plugged in
@cb1kenobi cb1kenobi merged commit 98093a1 into tidev:master Sep 8, 2015
@FokkeZB
Copy link
Contributor Author

FokkeZB commented Sep 8, 2015

@cb1kenobi I have now:
#7143

@FokkeZB FokkeZB deleted the patch-24 branch September 8, 2015 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants