TIMOB-6187: Android: Re-enable Fastdev for V8 / Rhino #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into KrollAssetHelper.readAsset, moved some dependencies into kroll-common. TIMOB-6187
…kroll-v8.jar TIMOB-6187
… timob-6187 Conflicts: android/titanium/src/java/org/appcelerator/titanium/util/TiDownloadManager.java
|
Pull Accepted: |
|
|
||
| totalCount += count; | ||
| if (out != null) { | ||
| out.write(buffer, 0, count); |
There was a problem hiding this comment.
At this point, you could technically be writing beyond byteCount. Example: total stream is 1030 bytes, bufferSize is 1024 bytes and byteCount (the desired number of bytes) is 1028. The second iteration of this loop would grab 1025-1030 and put it in out, even though only up to 1028 was desired.
from KrollStreamHelper.pumpCount. TIMOB-6187
|
Code review + functional test accepted |
… timob-6187 Conflicts: android/runtime/common/src/java/org/appcelerator/kroll/KrollApplication.java
| readDeployData(deployData); | ||
|
|
||
| if (enabled && fastDevSocket != null) | ||
| { |
There was a problem hiding this comment.
Move curly onto the same line as the "if" statement.
|
Code reviewed and accepted PENDING resolution of comments for TiFastDev::102 and KrollStreamHelper::65 |
|
Code reviewed. accepted |
joshthecoder
added a commit
that referenced
this pull request
Nov 21, 2011
TIMOB-6187: Android: Re-enable Fastdev for V8 / Rhino
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-6187
Testing instructions are on the JIRA issue