[TIMOB-19475] Android: Build fails if target SDK is lower than API 23 #7139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1102,7 +1102,7 @@ AndroidBuilder.prototype.validate = function validate(logger, config, cli) { | |||
| // target sdk is too old | |||
| if (this.realTargetSDK < this.minTargetApiLevel) { | |||
| logger.error(__('The target SDK %s is not supported by Titanium SDK %s', this.targetSDK + (this.targetSDK !== this.realTargetSDK ? ' (' + this.realTargetSDK + ')' : ''), ti.manifest.version)); | |||
| logger.error(__('The target SDK version must be %s or newer', this.minTargetApiLevel) + '\n'); | |||
| logger.error(__('The target SDK version must be %s', this.minTargetApiLevel) + '\n'); | |||
There was a problem hiding this comment.
I'm not sure about this. So, yes we only support api 23, but if the target sdk is greater than 23, we don't really error out... only if it's less than 23. So, it should be safe to leave the "or newer".
|
APPROVED |
cb1kenobi
added a commit
that referenced
this pull request
Sep 8, 2015
[TIMOB-19475] Android: Build fails if target SDK is lower than API 23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-19475