New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-17693] Support new AlertDialog properties #7155
Conversation
@@ -35,7 +35,9 @@ -(NSMutableDictionary*)langConversionTable | |||
@"title",@"titleid", | |||
@"ok",@"okid", | |||
@"message",@"messageid", | |||
nil]; | |||
@"loginPlaceholder", @"passwordPlaceholder", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation here should be consistent with the above. use tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of adding these 3 new objects here? This is a dictionary with Objects and Keys, there's no corresponding keys for these objects.
FT done. Please address comments. |
@cheekiatng Fixed the conversation table |
APPROVED. |
[TIMOB-17693] Support new AlertDialog properties
JIRA: https://jira.appcelerator.org/browse/TIMOB-17693