[TIMOB-19555] HTTPClient fails when no contentType is specified #7210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
changed the title
|
Hi Mano, thank you for your PR! Can you check the indentation level to be conform with the rest of the code? Our legacy code often has tabs instead of spaces. Thank you! |
|
@hansemannn: Hope it meets the indentation level now. |
ashcoding
changed the title
|
Jira ticket https://jira.appcelerator.org/browse/TIMOB-19555 |
|
Code reviewed and functionally tested with test code in jira ticket. Working well. 👍 Thanks @mano-mykingdom |
ashcoding
added a commit
that referenced
this pull request
Sep 21, 2015
[TIMOB-19555] HTTPClient fails when no contentType is specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/AC-365
Modified cod for null check of contentType