[TIMOB-19295] iOS9: Titanium CLI automatically converts existing images to assets catalog #7231
Conversation
| @@ -4002,6 +4003,7 @@ iOSBuilder.prototype.copyResources = function copyResources(next) { | |||
| // fall through to default case | |||
|
|
|||
| default: | |||
| imageAssets[relPath] = info; | |||
There was a problem hiding this comment.
I'm not sure this is a good idea. Images are going to be copied into the app twice: once as they do now and again into the asset catalog.
You should add a 'jpg' and 'png' case above it and track imageAssets separately. This case should be BEFORE 'html' as 'html' is designed to fall through.
|
No where are you deleting these images from |
| // update image file's destination | ||
| imageAssets[file].dest = path.join(imageSetAbsPath, imageName + '.' + imageExt); | ||
|
|
||
| if (!(imageSetRelPath in imageSets)) { |
There was a problem hiding this comment.
Generally the in operator is frowned down upon. You can generally say !imageSets[imageSetRelPath], but sometimes you need to do !imageSets.hasOwnProperty(imageSetRelPath).
feons
force-pushed
the
TIMOB-19295
branch
2 times, most recently
from
d165b1a
to
51cee5e
Compare
| name: imageSetName | ||
| } | ||
|
|
||
| fs.existsSync(imageSetAbsPath) || wrench.mkdirSyncRecursive(imageSetAbsPath); |
There was a problem hiding this comment.
This line is unnecessary.
feons
force-pushed
the
TIMOB-19295
branch
5 times, most recently
from
80c9192
to
397a762
Compare
…es to assets catalog
|
CR'd and FR'd. Looks grrrrrrrreat! APPROVED |
[TIMOB-19295] iOS9: Titanium CLI automatically converts existing images to assets catalog
https://jira.appcelerator.org/browse/TIMOB-19295