[TIMOB-19615] iOS: Suppress missing UIBackgroundModes "fetch" and "remote-notification" warnings #7257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| if (Array.isArray(infoPlist.UIBackgroundModes) && infoPlist.UIBackgroundModes.indexOf('fetch') !== -1) { | ||
| contents += '\n#define USE_TI_FETCH'; | ||
| } |
There was a problem hiding this comment.
This will only add these #defines if you're building for simulator or including all ti modules. That means device and dist builds will never have these set. These new lines should probably be moved after this if/else block and before the if (!destExists || contents !== fs.readFileSync(dest).toString()) { line.
There was a problem hiding this comment.
But device builds were already addressed here at this line:
https://github.com/appcelerator/titanium_mobile/blob/master/iphone/cli/commands/_build.js#L4959
|
CR'd and FR'd. APPROVED |
cb1kenobi
added a commit
that referenced
this pull request
Oct 1, 2015
[TIMOB-19615] iOS: Suppress missing UIBackgroundModes "fetch" and "remote-notification" warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-19615