[TIMOB-19708, TIMOB-19709, TIMOB-19710, TIMOB-19711, TIMOB-19712, TIMOB-19713, TIMOB-19714, TIMOB-19715] Fix and improve UIApplicationShortcuts #7290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,5 +57,23 @@ | |||
| <string>UIInterfaceOrientationLandscapeLeft</string> | |||
| <string>UIInterfaceOrientationLandscapeRight</string> | |||
| </array> | |||
| <key>UIApplicationShortcutItems</key> | |||
There was a problem hiding this comment.
Uh.. you don't actually want this in the plist template right? ;)
There was a problem hiding this comment.
Will be ignored on non-supported devices and improves KitchenSink testing, so its ok to leave it there.
There was a problem hiding this comment.
But on devices that do support it, won't it make this shortcut appear without the developer expecting it to?
|
@hansemannn added some comments to the code. Also, the title of this PR should have all JIRA tickets or they won't be linked from the JIRA ticket. |
FokkeZB
added a commit
to appcelerator-developer-relations/appc-sample-3dtouch
that referenced
this pull request
Oct 13, 2015
hansemannn
changed the title
hansemannn
changed the title
|
PR Reviewed. APPROVED! |
pec1985
added a commit
that referenced
this pull request
Oct 13, 2015
[TIMOB-19708, TIMOB-19709, TIMOB-19710, TIMOB-19711, TIMOB-19712, TIMOB-19713, TIMOB-19714, TIMOB-19715] Fix and improve UIApplicationShortcuts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA tickets:
Updated demo: https://gist.github.com/hansemannn/c6daf98c25fd7635d1cf
/cc @FokkeZB @benbahrenburg