Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-19383] iOS9: Upgrade Facebook module to facebook 4.7.0 #7292

Merged
merged 1 commit into from Oct 13, 2015

Conversation

cheekiatng
Copy link
Contributor

@hansemannn
Copy link
Collaborator

FT and CR passed, PR approved. Thank you @cheekiatng !

hansemannn added a commit that referenced this pull request Oct 13, 2015
[TIMOB-19383] iOS9: Upgrade Facebook module to facebook 4.7.0
@hansemannn hansemannn merged commit 4ccdb96 into tidev:master Oct 13, 2015
@bogdansmc
Copy link
Contributor

I confirm app crash on iOS.
As well, authorize doesn't work too (version 4.0.5 works well)

@cheekiatng
Copy link
Contributor Author

HI everyone, it'll be great if you could include more details of the environment you are on. Like:

  1. Xcode Version.
  2. iOS Version.
  3. Titanium SDK Version (Has to be 5.0.0 and above).
    Also, please make sure you read the changes for replaced methods and make sure to follow the NEW instructions to configure the module.

@bogdansmc
Copy link
Contributor

Dear cheekiatng, what new instructions are with using 4.0.5?
I use only simple login functions, there is not changes here!
And as it is described by arnaudm, app crashes after close/reopen without facebook authorize or other functions!

Xcode Version 7.0.1 (7A1001)
ios 8.4, 9.0
Titanium SDK Version 5.0.2.GA

@bogdansmc
Copy link
Contributor

The last step-by-step to reproduce:

  1. create new mobile app project (Default Alloy Project)
  2. install facebook module 5.0.0 into project
  3. add var fb = require('facebook'); in controllers/index.js before $.index.open();
  4. Run on simulator iphone 4s, ios 8.4
  5. After app start press "home" button and run app again.
    App will crash after that!

MacOS 10.11 (15A284)
Appcelerator Studio, build: 4.3.1.201509302304
Xcode Version 7.0.1 (7A1001)
ios 8.4
Titanium SDK Version 5.0.2.GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants