Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-19722] [TIMOB-19579]: fixes NullPointerException in TiConvert #7295

Merged
merged 1 commit into from Oct 14, 2015

Conversation

manumaticx
Copy link
Contributor

No description provided.

@ashcoding
Copy link
Contributor

Nice catch! 👍 👍

@ashcoding
Copy link
Contributor

Code reviewed and functionally tested with this code:

var window = Ti.UI.createWindow({backgroundColor: "white"});
var view = Ti.UI.createView({});
var view2 = Ti.UI.createView({width: 100, height: 100, backgroundColor: "yellow"});
view.add(view2);
var button = Ti.UI.createButton({title: "Hide/show view w/ circular animation"});
button.addEventListener("click", function(e) {
    if (view.visible) {
        view.hide();
    } else {
        view.show();
    }
});
window.add(view);
window.add(button);
window.open();

@ashcoding
Copy link
Contributor

Approved

ashcoding added a commit that referenced this pull request Oct 14, 2015
[TIMOB-19579]: fixes NullPointerException in TiConvert
@ashcoding ashcoding merged commit f94ae3d into tidev:master Oct 14, 2015
@ashcoding
Copy link
Contributor

@ashcoding ashcoding changed the title [TIMOB-19579]: fixes NullPointerException in TiConvert [TIMOB-19722] [TIMOB-19579]: fixes NullPointerException in TiConvert Oct 14, 2015
@manumaticx manumaticx deleted the TIMOB-19579 branch February 3, 2016 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants