Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-19716] Support contact icon in UIApplicationShortcuts #7299

Merged
merged 2 commits into from Oct 14, 2015
Merged

[TIMOB-19716] Support contact icon in UIApplicationShortcuts #7299

merged 2 commits into from Oct 14, 2015

Conversation

hansemannn
Copy link
Collaborator

cheekiatng
cheekiatng reviewed Oct 14, 2015
View reviewed changes
apidoc/Titanium/UI/iOS/ApplicationShortcuts.yml
The icon to be displayed on the application shortcut, for example <Titanium.UI.iOS.SHORTCUT_ICON_TYPE_COMPOSE>.
Note: You can also use a local image specified by the image path.
type: Number
The icon to be displayed on the application shortcut. You can either use one of the contastants like
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling: not contestants, but constants

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed your comment in the latest commit, thanks!

@cheekiatng
Copy link
Contributor

CR and FT passed. 2 questions:
in your example app:

  1. i tried doing "Add Shortcut" twice with 2 different contacts. but there's only 1 shortcut appearing. which is the first add. is this expected behavior?
  2. Assuming it is the expected behavior, shouldn't the 2nd "add shortcut" overwrite the first? because the first contact always appears (until i chose remove)

@hansemannn
Copy link
Collaborator Author

The first button is "Add Ti.Contacts Application Shortcut" to create a shortcut and the second is "Remove Ti.Contacts Application Shortcut" to remove the previous created shortcut to allow the tester to test some contacts.

@cheekiatng
Copy link
Contributor

APPROVED!

cheekiatng added a commit that referenced this pull request Oct 14, 2015
@cheekiatng
Merge pull request #7299 from hansemannn/TIMOB-19716
7c8d24f 
[TIMOB-19716] Support contact icon in UIApplicationShortcuts
@cheekiatng cheekiatng merged commit 7c8d24f into tidev:master Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hansemannn @cheekiatng