[TIMOB-19765] Android: Support running on main/UI thread #7332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thread via an app property
sgtcoolguy
changed the title
|
@cb1kenobi i think will need to add a change to read the XML property directly underneath android in tiapp.xml. I ran into this problem with another hyperloop tiapp.xml change i wanted to make. |
|
@jhaynie no problem. Create a ticket with what you need and it'll get done. |
|
@jhaynie @cb1kenobi I opened up https://jira.appcelerator.org/browse/TIMOB-19797 to track the handling of platform-specific XML in tiapp.xml and access it at runtime. |
|
@hieupham007 Hey Hieu, can you take a look at this and we'll circle back to using the property under the android tag once TIMOB-19797 lands. |
|
Code reviewed, looks good. |
sgtcoolguy
added a commit
that referenced
this pull request
Oct 27, 2015
[TIMOB-19765] Android: Support running on main/UI thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-19765
This simply looks for a boolean property named "run-on-main-thread" in your tiapp to toggle which thread to use.
Based on that flag we will basically merge the "Main" and "UI" messengers.