[TIMOB-5163] Creating Ti.Facebook.BUTTON_STYLE_WIDE/NORMAL constants and replacing the 'wide' and 'normal' strings #734
Conversation
…and replacing the 'wide' and 'normal' strings
| @@ -6,6 +6,6 @@ since: "0.8" | |||
| platforms: [android, iphone, ipad] | |||
| properties: | |||
| - name: style | |||
| description: set to "wide" to show a wider version of the button that displays "Connect with Facebook" instead of just "Connect". | |||
| description: set to "Ti.Facebook.BUTTON_STYLE_WIDE" to show a wider version of the button that displays "Connect with Facebook" and "Ti.Facebook.BUTTON_STYLE_NORMAL" shows just "Connect". | |||
There was a problem hiding this comment.
Since this won't get fixed for Android in 1.8 description should probably say use the constants for iOS and the old strings for Android?
|
Ready for review. |
|
Code reviewed. APPROVED. |
|
All facebook tests only display STYLE_WIDE; we need at least one which displays STYLE_NORMAL. It's also worth noting that STYLE_WIDE is apparently the default on iOS, even before this pull request; maybe we should rename these constants to reflect that (STYLE_NORMAL and STYLE_SMALL?) |
|
Passes functional testing. APPROVED, but... |
|
We should address the issue of the functional test only testing |
|
Functional retest, iOS Sim 4.3 / iPod 3GT 5.0. APPROVED, and ACCEPTED. |
[TIMOB-5163] Creating Ti.Facebook.BUTTON_STYLE_WIDE/NORMAL constants and replacing the 'wide' and 'normal' strings
Replacing the old styling string "wide" and "normal " with constants Ti.Facebook.BUTTON_STYLE_WIDE and Ti.Facebook.BUTTON_STYLE_NORMAL
Testing
Test KitchenSink > Mashups > Facebook > Login/Logout
Check to see if you can see the button there.
additional test file included in Jira.