[TIMOB-19580] Customize Activity Transitions #7371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just glancing through the code. There seems to be some slight formatting issues. Will comment on those parts of the code. |
| @@ -91,6 +93,19 @@ | |||
| public static final int SOFT_KEYBOARD_DEFAULT_ON_FOCUS = 0; | |||
| public static final int SOFT_KEYBOARD_HIDE_ON_FOCUS = 1; | |||
| public static final int SOFT_KEYBOARD_SHOW_ON_FOCUS = 2; | |||
|
|
|||
| public static final int TRANSITION_NONE = 0; | |||
There was a problem hiding this comment.
The variables are not formatted with the variables above.
|
Please review the updated commit. |
|
Code reviewed. Functionally tested. Accepted |
ashcoding
added a commit
that referenced
this pull request
Oct 30, 2015
[TIMOB-19580] Customize Activity Transitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA https://jira.appcelerator.org/browse/TIMOB-19580?filter=-1