Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-19777] iOS: Disable new UITableView property by default #7393

Merged
merged 3 commits into from Nov 4, 2015

Conversation

AngelkPetkov
Copy link
Contributor

:JIRA: https://jira.appcelerator.org/browse/TIMOB-19777
cellLayoutMarginsFollowReadableWidth

@hansemannn hansemannn changed the title [TIMOB-19777]:Dissabled new tableView property [TIMOB-19777] iOS: Disabled new tableView property Nov 4, 2015
if ([TiUtils isIOS9OrGreater]) {
_tableView.cellLayoutMarginsFollowReadableWidth = NO;
}

return _tableView;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do this check before line 200 in the initial creation of the UITableView. Also make sure to use the IS_XCODE_7 macro to not break Xcode 6 builds.

@hansemannn hansemannn changed the title [TIMOB-19777] iOS: Disabled new tableView property [TIMOB-19777] iOS: Disable new UITableView property by default Nov 4, 2015
@hansemannn
Copy link
Collaborator

CR + FT passed, APPROVED!

hansemannn added a commit that referenced this pull request Nov 4, 2015
[TIMOB-19777] iOS: Disable new UITableView property by default
@hansemannn hansemannn merged commit 80f2c5c into tidev:master Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants