Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-6242 Android bitmap memory leak #743

Merged
merged 1 commit into from Nov 21, 2011
Merged

TIMOB-6242 Android bitmap memory leak #743

merged 1 commit into from Nov 21, 2011

Conversation

billdawson
Copy link
Contributor

http://jira.appcelerator.org/browse/TIMOB-6242

Please test at least these two things (in V8 and Rhino):

@marshall
Copy link
Contributor

The reason for the V8 / Rhino difference probably has to do with JNI Global references on the native side for the V8 runtime.

Technically MAT is correct in saying that each proxy is a GC root, because in JNI, to hold a reference to a Java object inside a V8 JS Object, we use a Global reference. The Java object also holds a pointer to the underlying Persistent V8 reference, so when either Garbage Collector kicks in, we free both references.

There may be another leak in our JS that causes V8 to hold on to the original view instance, possibly in our window.js?

@marshall
Copy link
Contributor

Code and Functional review passed, Request accepted.

@rusticphilosopher
Copy link
Contributor

Code reviewed and accepted. Merging.

rusticphilosopher pushed a commit that referenced this pull request Nov 21, 2011
TIMOB-6242 Android bitmap memory leak
@rusticphilosopher rusticphilosopher merged commit 91253ba into tidev:master Nov 21, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants