TIMOB-6008 Add android support for the new Titanium.Platform.runtime property #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,6 +28,8 @@ describe("Ti.Platform tests", { | |||
| valueOf(Ti.Platform.ostype).shouldBeString(); | |||
| valueOf(Ti.Platform.processorCount).shouldBeNumber(); | |||
| valueOf(Ti.Platform.version).shouldBeString(); | |||
| valueOf(Ti.Platform.runtime).shouldBeString(); | |||
| valueOf(Ti.Platform.runtime.length).shouldBeGreaterThan(0); | |||
There was a problem hiding this comment.
wonder if there should be platform specific versions to test that it's one of the valid platform types if known?
|
Sorry, I didn't realize the documentation was in a different ticket. I've added the link to TIMOB-6011 above in the description. Be sure to close that ticket as well when merged. |
|
Code reviewed. Request accepted. |
|
Pull accepted: |
|
Code reviewed. Request Accepted |
donthorp
added a commit
that referenced
this pull request
Nov 22, 2011
TIMOB-6008 Add android support for the new Titanium.Platform.runtime property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.appcelerator.org/browse/TIMOB-6008
http://jira.appcelerator.org/browse/TIMOB-6011
Test is the "platform" test in Drillbit. Need to run in both V8 (
--android-runtime=v8) and Rhino (--android-runtime=rhino).UPDATE:
Sorry, I didn't realize the documentation was in a different ticket. I've added the link to 6011 above. Be sure to close that ticket as well when merged.