Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-20059] iOS: 'person' property in Ti.Contacts.showContacts is e… #7517

Merged
merged 1 commit into from Dec 1, 2015

Conversation

sriks
Copy link
Contributor

@sriks sriks commented Dec 1, 2015

https://jira.appcelerator.org/browse/TIMOB-20059
Updated the docs to add more info about person property.

@@ -540,6 +540,10 @@ properties:
by Apple.
Since iOS 9.0, there is a native apple issue whereby it may return null if the birthday property
is selected on certain device models.
The callback contains the selected property and a 'person' object of type <Titanium.Contacts.Person>.
Since iOS 9.0, there is a native apple issue whereby the person is a partially object and not all
properties are available by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since iOS 9.0, apple only returns a person object with partial information. Currently it is known to only contain these properties: ? ? ?

@sriks sriks force-pushed the TIMOB-20059 branch 2 times, most recently from add67c6 to f3b6591 Compare December 1, 2015 06:52
@sriks
Copy link
Contributor Author

sriks commented Dec 1, 2015

Updated PR with review changes.

@@ -540,6 +540,9 @@ properties:
by Apple.
Since iOS 9.0, there is a native apple issue whereby it may return null if the birthday property
is selected on certain device models.
The callback contains the selected property and a 'person' object of type <Titanium.Contacts.Person>.
Since iOS 9.0, apple only returns the person object with partial information. Currently it is known to
atleast contain the selected property and fullName.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least

@cheekiatng
Copy link
Contributor

APPROVED!

cheekiatng added a commit that referenced this pull request Dec 1, 2015
[TIMOB-20059] iOS: 'person' property in Ti.Contacts.showContacts is e…
@cheekiatng cheekiatng merged commit cc256f7 into tidev:master Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants