Fix TC-5784 - setting a view layout to null on android crashes the app #7529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierlacot
force-pushed
the
fix/TC-5784
branch
from
72e8ffb
to
37dd8c7
Compare
…ring it to horizontal or vertical layout arrangements
xavierlacot
force-pushed
the
fix/TC-5784
branch
from
37dd8c7
to
a0ec81c
Compare
|
@xavierlacot thanks for the PR. |
|
Code reviewed and functionally tested. Request Accepted. 👍 |
ashcoding
added a commit
that referenced
this pull request
Dec 3, 2015
Fix TC-5784 - setting a view layout to null on android crashes the app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug described in the ticket TC-5784.
The
TiViewclass constructor does not correctly check that the layout property is not null, and it crashes when calling theequals()method. This PR assumes that, when a null layout is passed, the layout will default to a composite layout (the default value).