[TIMOB-20002]: iOS: Ti.Geolocation.requestLocationPermissions is not … #7539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…always called? - fixed main thread issue
| @@ -869,7 +869,9 @@ -(void)requestLocationPermissions:(id)args | |||
| (currentPermissionLevel == kCLAuthorizationStatusAuthorized)) { | |||
| errorMessage = @"Cannot change already granted permission from AUTHORIZATION_ALWAYS to AUTHORIZATION_WHEN_IN_USE"; | |||
| } else if (!userDidApproveOrReject) { | |||
| [[self locationPermissionManager] requestWhenInUseAuthorization]; | |||
| dispatch_async(dispatch_get_main_queue(), ^{ | |||
There was a problem hiding this comment.
Should use TiThreadPerformOnMainThread(^{
[[self locationPermissionManager] requestWhenInUseAuthorization];
}, NO); instead. As it does a couple of checks regarding the main thread to prevent crashes.
|
Closing the PR sorry ,because it doesn't fully fix the issue, the callback will still print Success even if we disallow access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA https://jira.appcelerator.org/browse/TIMOB-20002
This addresses the issue of invoking location permissions not in main thread.