Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-6207] Replaced one dependency with a portable version so that pro... #757

Merged
merged 2 commits into from Nov 23, 2011
Merged

[TIMOB-6207] Replaced one dependency with a portable version so that pro... #757

merged 2 commits into from Nov 23, 2011

Conversation

nebrius
Copy link
Contributor

@nebrius nebrius commented Nov 22, 2011

...jects will compile on Windows.

@donthorp
Copy link
Contributor

Code reviewed. Request accepted

@billdawson
Copy link
Contributor

Code Reviewed. Request accepted

@DustinHyde
Copy link

Pull Rejected.
Build fails with similar error (below).
Tested on Windows 7 and Windows XP.

Error:

Traceback (most recent call last):
File "C:\Users\labuser\AppData\Roaming\Titanium\mobilesdk\win32\1.8.0.1.pull75
7\mobileweb\builder.py", line 8, in
import compiler
File "C:\Users\labuser\AppData\Roaming\Titanium\mobilesdk\win32\1.8.0.1.pull75
7\mobileweb\compiler.py", line 12, in
import simplejson as json
ImportError: No module named simplejson

@eric34
Copy link
Contributor

eric34 commented Nov 23, 2011

Pull accepted:
Verified on win 7 64 bit with google chrome and firefox. Also verified on Win XP 32 bit with firefox (IE 8 unsupported). Encountered known analytics "true" additional pop-up windows.

@donthorp
Copy link
Contributor

Code reviewed. Request accepted

@billdawson
Copy link
Contributor

Code reviewed. Request accepted.

donthorp added a commit that referenced this pull request Nov 23, 2011
[TIMOB-6207] Replaced one dependency with a portable version so that pro...
@donthorp donthorp merged commit 821fd58 into tidev:master Nov 23, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants