[TIMOB-20147] iOS: Ti.Contacts.showContacts() selectedPerson returns … #7585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| TiContactsPerson* person = nil; | ||
| if ([TiUtils isIOS8OrGreater] && (ABAddressBookGetAuthorizationStatus() != kABAuthorizationStatusAuthorized)) { | ||
| // In iOS 8 selected contact is returned without requiring user permission. But we cannot query metadata like recordid. | ||
| person = [[[TiContactsPerson alloc] _initWithPageContext:[self executionContext] |
There was a problem hiding this comment.
Is this shifted again or is Github messing stuff up? (http://abload.de/img/bildschirmfoto2015-12fna51.png)
There was a problem hiding this comment.
Looks like objective-c style method formatting is the issue. Changed it to single line. Please check.
| description: For iOS 9 and later, use the [identifier](Titanium.Contacts.Person.identifier) property. | ||
| description: For iOS 9 and later, use the [identifier](Titanium.Contacts.Person.identifier) property. | ||
| In iOS 8, a contact can be selected without requiring User permission. In such case this | ||
| property returns -1. |
There was a problem hiding this comment.
Does the validate.py accept this change? The format for multiline yaml should be:
description: |
For iOS 9 and later, use the [identifier](Titanium.Contacts.Person.identifier) property.
In iOS 8, a contact can be selected without requiring User permission. In such case this
property returns -1.There was a problem hiding this comment.
validate.py is not complaining. But I did change to use new line format. Please check.
AngelkPetkov
added a commit
that referenced
this pull request
Dec 23, 2015
[TIMOB-20147] iOS: Ti.Contacts.showContacts() selectedPerson returns …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA https://jira.appcelerator.org/browse/TIMOB-20147