Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-20176] iOS: Support UIVisualEffectView #7599

Merged
merged 5 commits into from Jan 28, 2016

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn changed the title [TIMOB-20176] Support UIVisualEffectView [TIMOB-20176] iOS: Support UIVisualEffectView Dec 24, 2015
if (TiDimensionIsAuto(width) || TiDimensionIsAutoSize(width) || TiDimensionIsUndefined(width) ||
TiDimensionIsAuto(height) || TiDimensionIsAutoSize(height) || TiDimensionIsUndefined(height)) {
return UIViewContentModeScaleAspectFit;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

} else {...}

Use trailing { to be in consistent with rest of code.

@sriks
Copy link
Contributor

sriks commented Jan 28, 2016

@hansemannn
Minor code formatting recommendations.
Everything else looks good.

sriks added a commit that referenced this pull request Jan 28, 2016
[TIMOB-20176] iOS: Support UIVisualEffectView
@sriks sriks merged commit 2919920 into tidev:master Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants