[TIMOB-20178] Support Peek and Pop in Ti.UI.WebView #7600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [webview setAllowsLinkPreview:[TiUtils boolValue:value]]; | ||
| #endif | ||
| } | ||
|
|
There was a problem hiding this comment.
Return type is id but returns nothing, this will crash on device
There was a problem hiding this comment.
Didn't crash on the iPhone 6S test device, but of course it needs to be void. Fixed.
|
PR reviewed. APPROVED! |
pec1985
added a commit
that referenced
this pull request
Dec 28, 2015
[TIMOB-20178] Support Peek and Pop in Ti.UI.WebView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-20178