Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-20189] Android: Update AttributeProxy to allow fontStyle to be set without having fontWeight to be manually set. #7605

Merged
merged 1 commit into from Jan 5, 2016

Conversation

collinprice
Copy link
Contributor

On Android, a user had to manually specify fontWeight and fontStyle when they wanted to add only a fontStyle to an AttributedString.

For example:

This would do nothing on Android

  Ti.UI.createAttributedString({
    text: "Hello World",
    attributes: [
        {
            type: Ti.UI.ATTRIBUTE_FONT,
            value: { fontStyle: "italic" },
            range: [0, 5]
        }
    ]
})

A user would have to add a fontWeight for the text to be "italic"

 Ti.UI.createAttributedString({
    text: "Hello World",
    attributes: [
        {
            type: Ti.UI.ATTRIBUTE_FONT,
            value: { fontWeight: "normal", fontStyle: "italic" },
            range: [0, 5]
        }
    ]
})

@collinprice
Copy link
Contributor Author

Travis build fail seems to be unrelated to pull request. Going to close and reopen.

@collinprice
Copy link
Contributor Author

Attempting to restart Travis build.

@collinprice collinprice reopened this Dec 30, 2015
@hansemannn
Copy link
Collaborator

@collinprice Can you file a JIRA ticket to be referenced here?

@collinprice
Copy link
Contributor Author

Created: https://jira.appcelerator.org/browse/TIMOB-20189

EDIT by Hans: Moved ticket to TIMOB, thanks!

@hansemannn hansemannn changed the title Updated AttributeProxy to allow fontStyle to be set without having fontWeight to be manually set. [TIMOB-20189] iOS: Update AttributeProxy to allow fontStyle to be set without having fontWeight to be manually set. Jan 4, 2016
@collinprice collinprice changed the title [TIMOB-20189] iOS: Update AttributeProxy to allow fontStyle to be set without having fontWeight to be manually set. [TIMOB-20189] Android: Update AttributeProxy to allow fontStyle to be set without having fontWeight to be manually set. Jan 4, 2016
@hansemannn
Copy link
Collaborator

Approved, thank you @collinprice!

hansemannn added a commit that referenced this pull request Jan 5, 2016
[TIMOB-20189] Android: Update AttributeProxy to allow fontStyle to be set without having fontWeight to be manually set.
@hansemannn hansemannn merged commit fa00564 into tidev:master Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants