Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-20196] iOS: ScrollableView is not possible to change views #7617

Merged
merged 2 commits into from Jan 6, 2016

Conversation

AngelkPetkov
Copy link
Contributor

@pec1985
Copy link
Contributor

pec1985 commented Jan 6, 2016

Good catch! That also fixes another bug. This PR #7553 is wrong and needs to be corrected. If you could, do these changes:
From

#ifndef TI_USE_AUTOLAYOUT
    ENSURE_UI_THREAD(setViews, args)
#endif

to

#ifdef TI_USE_AUTOLAYOUT
    ENSURE_UI_THREAD(setViews, args)
#endif

And then move this line to the end of the function

[self replaceValue:args forKey:@"views" notification:YES];

Let me know if you have questions

@pec1985
Copy link
Contributor

pec1985 commented Jan 6, 2016

@AngelkPetkov
Copy link
Contributor Author

Thanks! Addressed comment.

@pec1985
Copy link
Contributor

pec1985 commented Jan 6, 2016

Thanks!

pec1985 added a commit that referenced this pull request Jan 6, 2016
[TIMOB-20196] iOS: ScrollableView is not possible to change views
@pec1985 pec1985 merged commit baaf4ee into tidev:master Jan 6, 2016
AngelkPetkov added a commit to AngelkPetkov/titanium_mobile that referenced this pull request Jan 11, 2016
AngelkPetkov added a commit to AngelkPetkov/titanium_mobile that referenced this pull request Jan 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants