Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-20196](5_2_X) iOS: ScrollableView is not possible to change views #7627

Merged
merged 1 commit into from Jan 11, 2016
Merged

[TIMOB-20196](5_2_X) iOS: ScrollableView is not possible to change views #7627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions iphone/Classes/TiUIScrollableViewProxy.m
View file
Open in desktop
Expand Up @@ -71,7 +71,7 @@ -(NSUInteger)viewCount

-(void)setViews:(id)args
{
#ifndef TI_USE_AUTOLAYOUT
#ifdef TI_USE_AUTOLAYOUT
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is reverted ~line 74 ifndef to ifdef in the versions 5.1.2 and 5.2.RC now the RE setView() freez the app.

I just tested now withifndefand the app not freez anymore.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nuno, sounds critical. Can you describe some more details on the related ticket?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hansemannn Work on it now.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nuno Changing that line worked for me! Thanks mate!!!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hansemannn filed!

ENSURE_UI_THREAD(setViews, args)
#endif
ENSURE_ARRAY(args);
Expand All @@ -94,15 +94,14 @@ -(void)setViews:(id)args
[viewProxies autorelease];
viewProxies = [args mutableCopy];

[self replaceValue:args forKey:@"views" notification:NO];

#ifdef TI_USE_AUTOLAYOUT
for (TiViewProxy* proxy in viewProxies)
{
[[self view] addSubview:[proxy view]];
}
#endif
[self unlockViews];
[self replaceValue:args forKey:@"views" notification:YES];
}

-(void)addView:(id)args
Expand Down