Fix: "ti clean" does not scan SDK hooks #7628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for TIMOB-20085
Currently there's no chance for Titanium SDK to load "hooks" while
ti clean
even when you subscribeclean.post
event. It is required from Windows SDK to load hooks beforeti clean
because it uses special directory for Visual Studio.This PR basically gives platform-SDK a chance to load hooks before
ti clean
, viascanHooks
function in_clean.js
. platform-SDK that needs clean-hook should scan hooks incli/commands/_clean.js
, and then subscribeclean.pre
,clean.post
and so on._cli/commands/clean.js
cli/hooks/clean.js
See discussion in https://github.com/appcelerator/titanium_mobile_windows/pull/505 for more details.