New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TIMOB-20293 Add getFile method for Android #7653
Conversation
Thanks Ben! I can only see a (very minor) indentation issue. @ashcoding Can you review the method? Thanks guys! |
Fix indent
@@ -73,7 +73,7 @@ properties: | |||
setting file properties. | |||
type: Titanium.Filesystem.File | |||
permission: read-only | |||
platforms: [iphone,ipad] | |||
platforms: [android,iphone,ipad] | |||
since: "2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never had that before, but the docs seem to offer a way to set the since
property platform-dependent:
since:
android: "2.0.0"
iphone: "6.0.0"
ipad: "6.0.0"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't aware that was available.
Add platform level updates for since document property
@hansemannn looks like the since syntax recommended isn't supported. Any suggestions on an alternative? |
Maybe without quotes? Saw it inside the ListView.yml |
Starting to not be worth contributing
@hansemannn @ashcoding everything passed, "since" set to specific version numbers assuming the most recent is 6.0.0. |
Code reviewed. Functionally tested to be working. Setting to 6.0.0 documentation is fine. Will do changes for that documentation accordingly for you. |
Accepted |
TIMOB-20293 Add getFile method for Android
Doc update: #7724 |
Add Titanium.Database.DB.getFile() for Android.
Jira Ticket: https://jira.appcelerator.org/browse/TIMOB-20293
Tested using KitchenSink db