[TIMOB-19597] Android: Update for previewRect when no overlay is used #7660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @m1ga, there are a lot of blank spaces that produce a diff change. Can you check and eliminate them? Thanks! |
hansemannn
changed the title
|
@m1ga this PR is taken from your master branch? When you are reworking a fix you should work/fork from the fix branch itself i.e your TIMOB-19597 branch. That way only the required diff is captured. Other wise this PR is capturing a lot of other commits as well. |
|
@hansemannn sorry about all the blanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jira.appcelerator.org/browse/TIMOB-19597
When no overlay image is used it will return -1 (width, height)