[TIMOB-19769] (5_2_X) Android: Fix for fullscreen behavior in Camera

[ashcoding]

Jira: https://jira.appcelerator.org/browse/TIMOB-19769
PR #7552 caused an edge case issue for Camera.

Code to test:-

var self = Ti.UI.createWindow();
    var cameraOverlay = Titanium.UI.createView({
        backgroundColor: '#FF00FFAA'
    });

    var cameraOverlayButton = Titanium.UI.createImageView({
        bottom: 100,
        image: '/appcelerator_small.png',
    });
    cameraOverlay.add(cameraOverlayButton);

    cameraOverlay.addEventListener('click', function(e){
        Ti.API.info("taking pic");
        Ti.Media.takePicture();
    });

    self.addEventListener("postlayout", postlayoutHandler);
    function postlayoutHandler(e) {
        self.removeEventListener("postlayout", postlayoutHandler);
        Titanium.Media.showCamera({
            overlay: cameraOverlay,
            showControls: false,
            success: function(e) {
                  Ti.API.info('# SUCCESS : '+ JSON.stringify(e));
            },
            cancel: function(e) {
                  Ti.API.info('# CANCEL : '+e.error);

            },
            error: function(e) {
                  Ti.API.info('# ERROR : '+ e.code +' : '+ e.error);

            },
            mediaTypes:Ti.Media.MEDIA_TYPE_PHOTO,
        });
    }
    self.open();

[ashcoding]

This is for 5_2_X. Will add a Master branch PR once this is approved.

[sriks]

Since base class should be agnostic of derived classes, adding camera specific method in base class is not advised.

getWindow().addFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN); can be moved here. Also this is being used specifically for TiCameraActivity only.

[ashcoding]

I just moved the setFullscreenForCamera method into this class to address this in the updated commit.

[sriks]

@ashcoding please address the review comments.

[ashcoding]

Comments addressed @sriks. Please review again. Thank you.

[sriks]

checking for truth value is not required since we never set back from fullscreen.

[ashcoding]

@sriks, Comments addressed.

[sriks]

PR reviewed and merged!