Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-20357] Android: 9-patch padding box area ignored for Button backgroundImage #7696

Merged
merged 1 commit into from Feb 24, 2016

Conversation

falkolab
Copy link
Contributor

PR for JIRA

@ashcoding
Copy link
Contributor

Code reviewed and functionally tested by setting
button.backgroundImage = "/images/alert_button.png";

Accepted

ashcoding added a commit that referenced this pull request Feb 24, 2016
[TIMOB-20357] Android: 9-patch padding box area ignored for Button backgroundImage
@ashcoding ashcoding merged commit 65cc61e into tidev:master Feb 24, 2016
@falkolab
Copy link
Contributor Author

Sorry just saw your comment. It is wrong test case becouse bug inside processProperties but PR is functioning.

@ashcoding
Copy link
Contributor

Which test case are you referring to?

@falkolab
Copy link
Contributor Author

Ti.UI.createButton({backgroundImage:"/images/alert_button.png"})

But yesterday I tested this patch with other 9-patch image. And I found that button has not paddings defined in right and bottom area of 9-patch image. It have not 0 paddings, but different against defined in 9-patch.

I think need to reopen issue in JIRA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants