[TIMOB-20400] WWDR certificate can not be found in keychain other than system #7726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -166,7 +166,7 @@ function detect(options, callback) { | |||
| if (!code) { | |||
| var tmp = []; | |||
| parseCerts(out, tmp); | |||
| results.certs.wwdr = tmp.length && tmp[0].invalid === false; | |||
| results.certs.wwdr = results.certs.wwdr || (tmp.length && tmp[0].invalid === false); | |||
There was a problem hiding this comment.
results.certs.wwdr will never be truthy because if it was, the parent function would return on line 163.
There was a problem hiding this comment.
Mmm, right... but since the tasks for all keychains run in parallel the same task for another keychain might have set it to true between the test in 163 and when the subprocess calls back 166. So that's why it needs to be checked at both places.
There was a problem hiding this comment.
I see your point. I'm cool with the fix, but this is the wrong repo. The fix should go in ioslib, not titanium_mobile.
I went ahead and made the fix: tidev/ioslib#30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-20400