Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-20595] Module Build: Update pre and post compile hooks event name #7866

Merged
merged 2 commits into from Mar 19, 2016
Merged

[TIMOB-20595] Module Build: Update pre and post compile hooks event name #7866

merged 2 commits into from Mar 19, 2016

Conversation

feons
Copy link
Contributor

@feons feons commented Mar 18, 2016

@cb1kenobi
Copy link
Contributor

Looks good, however the build.pre.construct events are missing the module token.

@feons
Copy link
Contributor Author

feons commented Mar 18, 2016

What about build.finalize?

@cb1kenobi
Copy link
Contributor

Especially build.finalize. :)

@cb1kenobi
Copy link
Contributor

APPROVED

cb1kenobi added a commit that referenced this pull request Mar 19, 2016
@cb1kenobi
Merge pull request #7866 from feons/TIMOB-20595-master
d38b1de 
[TIMOB-20595] Module Build: Update pre and post compile hooks event name
@cb1kenobi cb1kenobi merged commit d38b1de into tidev:master Mar 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@feons @cb1kenobi